M1ngdaXie/MingdaOS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: extract layout constants to avoid magic numbers

Browse Source
This commit is contained in:
M1ngdaXie
2026-03-26 14:14:31 -07:00
parent bc6aa3407c
commit 814504db8c
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/config/layout.ts Normal file
View File

@@ -0,0 +1,2 @@
export const MENUBAR_HEIGHT = 28;
export const DOCK_HEIGHT = 72;

5
src/context/WindowContext.tsx
View File

@@ -1,6 +1,7 @@
import React, { createContext, useContext, useReducer, useCallback } from 'react'; import React, { createContext, useContext, useReducer, useCallback } from 'react';
import type { OSState, OSAction, WindowState } from '../types'; import type { OSState, OSAction, WindowState } from '../types';
import { APPS } from '../config/apps'; import { APPS } from '../config/apps';
import { MENUBAR_HEIGHT, DOCK_HEIGHT } from '../config/layout';
function initWindows(): Record<string, WindowState> { function initWindows(): Record<string, WindowState> {
const map: Record<string, WindowState> = {}; const map: Record<string, WindowState> = {};
@@ -85,9 +86,9 @@ function reducer(state: OSState, action: OSAction): OSState {
isMaximized: true, isMaximized: true,
prevPosition: { ...win.position }, prevPosition: { ...win.position },
prevSize: { ...win.size }, prevSize: { ...win.size },
position: { x: 0, y: 28 }, // 28px = menubar height position: { x: 0, y: MENUBAR_HEIGHT },
// viewport dims passed in from caller — keeps reducer pure // viewport dims passed in from caller — keeps reducer pure
size: { width: action.viewportWidth, height: action.viewportHeight - 28 - 72 }, size: { width: action.viewportWidth, height: action.viewportHeight - MENUBAR_HEIGHT - DOCK_HEIGHT },
}, },
}, },
}; };